Explicitly set basic.qos.global #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkomel
changed the title
|
CI environment seems to be broken in this repo. There are 4 tests failing, none of which is related to the changes within this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to explicitly set
basic.qos.globalwhen usingBasicQosorBasicConsume. SimpleAmqpClient library always sets this tofalsefor RabbitMq broker versions <v3.3.0 and totruefor versions >v3.3.0. This made it impossible to set QoS with this library when used with quorum-type queues in RabbitMq >v3.3.0.This pull request adds overrides to
BasicConsumeandBasicQos, making it is possible to explicitly setbasic.qos.globalsetting.This patch fixes #276