Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the libSimpleAmqpClient.pc.in template to avoid windows issues #337

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

MiguelBarro
Copy link
Contributor

  • Use the proper dll name suffixed with the version
  • Hint the boost includes in order to completely propagate boost dependency. This way FindBoost module can be avoided and with it any boost version issues.

…is propagated and FindBoost is not necessary in dependent projects)

Signed-off-by: Guybrush <[email protected]>
CMakeLists.txt Outdated
@@ -231,6 +231,11 @@ set(prefix ${CMAKE_INSTALL_PREFIX})
set(exec_prefix "\${prefix}")
set(libdir ${CMAKE_INSTALL_LIBDIR})
set(includedir "\${prefix}/include")
if(WIN32)
set(SimpleAmqpClient SimpleAmqpClient.${SAC_SOVERSION})
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SIMPLEAMQPCLIENT_LIB as the variable name.

@alanxz alanxz merged commit a531f72 into alanxz:master Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants