Fix #331 #340
Merged
Fix #331 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 98.70% 98.71%
=======================================
Files 28 28
Lines 1860 1869 +9
Branches 402 403 +1
=======================================
+ Hits 1836 1845 +9
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. |
orbeckst
requested changes
Jan 3, 2024
src/alchemlyb/parsing/parquet.py
Outdated
|
|
||
| from . import _init_attrs | ||
|
|
||
|
|
||
| @_init_attrs | ||
| def _check_metadata(path: str, T: float) -> pd.DataFrame: |
There was a problem hiding this comment.
The name is a bit misleading because it does not only check but also return a df. I would choose a name such as _read_parquet_with_metadata or similar.
xiki-tempula
force-pushed
the
331-parquet-file-can-now-save-metadata
branch
from
e7d5897 to
7f6d90e
Compare
orbeckst
approved these changes
Jan 3, 2024
|
RTD fails https://readthedocs.org/projects/alchemlyb/builds/23006311/ because PR #338 is not merged yet. I'll merge nevertheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow metadata to be loaded from the serialised parquet file.