Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): Cleanup and comments #39

Merged
merged 2 commits into from
Mar 14, 2024
Merged

feat(v2): Cleanup and comments #39

merged 2 commits into from
Mar 14, 2024

Conversation

adam-alchemy
Copy link
Contributor

Motivation

  • Inconsistent use of memory-safe and non-memory-safe assembly
  • Extraneous constant
  • Missing function comments

Solution

Annotate all assembly as memory-safe, remove extraneous constant, add comments.

jaypaik
jaypaik approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@jaypaik jaypaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@adam-alchemy adam-alchemy merged commit 8ef66a2 into develop Mar 14, 2024
2 checks passed
@adam-alchemy adam-alchemy deleted the adam/cleanup branch March 14, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypaik jaypaik jaypaik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-alchemy @jaypaik @adamegyed