Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [ALC-LA2-3] remove SignatureType.CONTRACT case from MultiOwnerLightAccount #51

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: [ALC-LA2-3] remove SignatureType.CONTRACT case from MultiOwnerLightAccount #51

merged 2 commits into from
Apr 5, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Apr 5, 2024

Removed this case for user op validation and adjusted tests.

@jaypaik jaypaik requested a review from a team April 5, 2024 21:26
Base automatically changed from 04-04-fix_address_best_practices to develop April 5, 2024 21:26
@jaypaik jaypaik force-pushed the 04-05-fix_ALC-LA2-3_remove_SignatureType.CONTRACT_case_from_MultiOwnerLightAccount__validateSignature_ branch from fc4cfe4 to a44a711 Compare April 5, 2024 21:26
howydev
howydev approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@howydev howydev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should also remove CONTRACT type signatures from the 1271 path but we can discuss more offline, otherwise LGTM

@jaypaik jaypaik force-pushed the 04-05-fix_ALC-LA2-3_remove_SignatureType.CONTRACT_case_from_MultiOwnerLightAccount__validateSignature_ branch from a44a711 to 097595b Compare April 5, 2024 22:48
@jaypaik jaypaik changed the title fix: [ALC-LA2-3] remove SignatureType.CONTRACT case from MultiOwnerLightAccount _validateSignature() fix: [ALC-LA2-3] remove SignatureType.CONTRACT case from MultiOwnerLightAccount Apr 5, 2024
@jaypaik jaypaik force-pushed the 04-05-fix_ALC-LA2-3_remove_SignatureType.CONTRACT_case_from_MultiOwnerLightAccount__validateSignature_ branch from 097595b to cb2548d Compare April 5, 2024 22:58
@jaypaik jaypaik merged commit 524ee49 into develop Apr 5, 2024
2 checks passed
@jaypaik jaypaik deleted the 04-05-fix_ALC-LA2-3_remove_SignatureType.CONTRACT_case_from_MultiOwnerLightAccount__validateSignature_ branch April 5, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howydev howydev howydev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaypaik @howydev