Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALC-7] add input validation to _initialize and _transferOwnership #6

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Sep 20, 2023

Addresses:
ALC-7: Missing Input Validation

@jaypaik jaypaik force-pushed the 09-20-fix_address_best_practices branch from 87d33aa to 581f73a Compare September 20, 2023 19:22
@jaypaik jaypaik force-pushed the 09-20-_ALC-7_add_input_validation_to__initialize_and__transferOwnership branch from 1775795 to 0004da5 Compare September 20, 2023 19:22
@jaypaik jaypaik force-pushed the 09-20-fix_address_best_practices branch from 581f73a to 84716cf Compare September 20, 2023 19:27
@jaypaik jaypaik force-pushed the 09-20-_ALC-7_add_input_validation_to__initialize_and__transferOwnership branch from 0004da5 to 1468da3 Compare September 20, 2023 19:27
Copy link
Collaborator

@howydev howydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howydev howydev force-pushed the 09-20-fix_address_best_practices branch 3 times, most recently from 84716cf to e07c3d6 Compare September 22, 2023 18:39
Base automatically changed from 09-20-fix_address_best_practices to 09-20-_ALC-5_update_initialized_from_uint8_to_uint64 September 22, 2023 19:09
@howydev howydev changed the base branch from 09-20-_ALC-5_update_initialized_from_uint8_to_uint64 to main September 22, 2023 19:12
@howydev howydev changed the base branch from main to 09-20-fix_address_best_practices September 22, 2023 19:16
@howydev howydev changed the base branch from 09-20-fix_address_best_practices to main September 22, 2023 19:27
@howydev howydev force-pushed the 09-20-_ALC-7_add_input_validation_to__initialize_and__transferOwnership branch from 1468da3 to d50e10c Compare September 22, 2023 19:28
@howydev howydev force-pushed the 09-20-_ALC-7_add_input_validation_to__initialize_and__transferOwnership branch from d50e10c to 48e1725 Compare September 22, 2023 19:31
@howydev howydev merged commit acdc79f into main Sep 22, 2023
@howydev howydev deleted the 09-20-_ALC-7_add_input_validation_to__initialize_and__transferOwnership branch September 22, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants