Show extended scan preview for strings. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scan preview for strings will be unbounded; their length will be determined solely by the null character. Bonus: Non-printable characters in scanned or watched strings will be replaced with the � character (the unrepresentable character). Fixes aldelaro5#79.
cristian64
force-pushed
the
extended_preview_strings
branch
from
6ae53f7
to
ebf0c66
Compare
dreamsyntax
approved these changes
Apr 28, 2024
cristian64
added a commit
to cristian64/dolphin-memory-engine
that referenced
this pull request
Aug 18, 2024
As the documentation states, the caller must check that the input character in [`std::isprint()`](https://en.cppreference.com/w/cpp/string/byte/isprint) is a valid `unsigned char`: > Like all other functions from `<cctype>`, the behavior of > `std::isprint` is undefined if the argument's value is neither > representable as `unsigned char` nor equal to `EOF`. To use these > functions safely with plain `char`s (or `signed char`s), the argument > should first be converted to `unsigned char`: > > ```cpp > bool my_isprint(char ch) > { > return std::isprint(static_cast<unsigned char>(ch)); > } > ``` The aforementioned undefined behavior manifests as a debug assertion when compiled with MSVC:  The affected functionality was introduced in aldelaro5#122. Fixes aldelaro5#173.
cristian64
added a commit
to cristian64/dolphin-memory-engine
that referenced
this pull request
Aug 18, 2024
As the documentation states, the caller must check that the input character in [`std::isprint()`](https://en.cppreference.com/w/cpp/string/byte/isprint) is a valid `unsigned char`: > Like all other functions from `<cctype>`, the behavior of > `std::isprint` is undefined if the argument's value is neither > representable as `unsigned char` nor equal to `EOF`. To use these > functions safely with plain `char`s (or `signed char`s), the argument > should first be converted to `unsigned char`: > > ```cpp > bool my_isprint(char ch) > { > return std::isprint(static_cast<unsigned char>(ch)); > } > ``` The aforementioned undefined behavior manifests as a debug assertion when compiled with MSVC:  The affected functionality was introduced in aldelaro5#122. Fixes aldelaro5#173.
dreamsyntax
pushed a commit
that referenced
this pull request
Aug 18, 2024
As the documentation states, the caller must check that the input character in [`std::isprint()`](https://en.cppreference.com/w/cpp/string/byte/isprint) is a valid `unsigned char`: > Like all other functions from `<cctype>`, the behavior of > `std::isprint` is undefined if the argument's value is neither > representable as `unsigned char` nor equal to `EOF`. To use these > functions safely with plain `char`s (or `signed char`s), the argument > should first be converted to `unsigned char`: > > ```cpp > bool my_isprint(char ch) > { > return std::isprint(static_cast<unsigned char>(ch)); > } > ``` The aforementioned undefined behavior manifests as a debug assertion when compiled with MSVC:  The affected functionality was introduced in #122. Fixes #173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan preview for strings will be unbounded; their length will be determined solely by the null character:
Bonus: Non-printable characters in scanned or watched strings will be replaced with the � character (the unrepresentable character).
Fixes #79.