Support array-of-bytes binary display #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've given it a go, and it works well. I've added a few comments, but I wouldn't be against to get it merged in its current state. (The macOS error appears to be unrelated; might need to retry.) |
|
@cristian64 I don't see your comments. Do you have a pending review that you forgot to click "Submit review" for? |
cristian64
reviewed
May 5, 2024
Source/Common/MemoryCommon.cpp
Outdated
Comment on lines
669
to
671
| u8 unsignedByte = 0; | ||
| std::memcpy(&unsignedByte, memory + i, sizeof(u8)); | ||
| ss << std::bitset<sizeof(u8) * 8>(unsignedByte).to_string() << " "; |
There was a problem hiding this comment.
I think this could be just:
ss << std::bitset<sizeof(u8) * 8>(Common::bit_cast<u8, char>(memory[i])).to_string() << " ";(Given that it's a single byte, not even the bit_cast would be necessary; a regular static_cast would work too.
Source/Common/MemoryCommon.cpp
Outdated
Comment on lines
680
to
682
| u8 aByte = 0; | ||
| std::memcpy(&aByte, memory + i, sizeof(u8)); | ||
| ss << std::setfill('0') << std::setw(2) << static_cast<int>(aByte) << " "; |
There was a problem hiding this comment.
Similarly, this could be:
ss << std::setfill('0') << std::setw(2)
<< static_cast<int>(Common::bit_cast<u8, char>(memory[i])) << " ";And, again, the bit_cast could just be a static_cast.
|
Those changes seem to work fine on my end, so I'm all for cleaning it up! |
dreamsyntax
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewing an
array of bytesentry as binary can be especially useful when observing bitfields. For example, Mario Kart Wii uses bitfields to track whether we are accelerating, braking, drifting, tricking, etc. Being able to view each bit in the field makes viewing the current state of each scenario a bit easier!I didn't add octal or decimal support, because I can't imagine any scenarios where such a display could be useful.