Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid prematurely freeing buffer during value editing on Linux. #141

Merged
merged 2 commits into from
May 16, 2024
Merged

Avoid prematurely freeing buffer during value editing on Linux. #141

merged 2 commits into from
May 16, 2024

Commits on May 16, 2024

  1. Remove wrong assertions. 

    These assertions were added in e9c0e22, but they are *not*
correct. A type size of 1 (e.g. `char`) can be encountered, and it is a
valid case that simply does not support any byte swapping.

(Another case had already been fixed in 11e56d6.)
    @cristian64
    cristian64 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7c97224 View commit details
    Browse the repository at this point in the history

  2. Avoid prematurely freeing buffer during value editing on Linux. 

    This was a regression in d58cd76, where the deletion of
the `bufferCopy` buffer was moved to an earlier point. It was overlooked
that the buffer is referenced by the `local` structure that used in the
`process_vm_writev()` call.
    @cristian64
    cristian64 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f7e45d1 View commit details
    Browse the repository at this point in the history