Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two crash bugs, add new context menu items #175

Merged
merged 6 commits into from
Aug 25, 2024

Conversation

camila314
Copy link
Contributor

  • Fixed a bug where opening a context menu with nothing selected crashed the program
  • Fixed a bug where adding pointer levels could crash the program
  • Created new 'Add Watch' and 'Add Group' context menu items when not selecting anything

Copy link
Collaborator

@cristian64 cristian64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first of the crashes was introduced [by me] in #171. The stack trace is:

#0  MemWatchTreeNode::getEntry() const (this=0x0) at /w/dolphin-memory-engine/Source/MemoryWatch/MemWatchTreeNode.cpp:61
#1  0x000055b08f3e877d in MemWatchModel::getEntryFromIndex(QModelIndex const&) (index=...) at /w/dolphin-memory-engine/Source/GUI/MemWatcher/MemWatchModel.cpp:122
#2  0x000055b08f3f6c70 in MemWatchWidget::onMemWatchContextMenuRequested(QPoint const&) (this=0x55b091538000, pos=...) at /w/dolphin-memory-engine/Source/GUI/MemWatcher/MemWatchWidget.cpp:277
#3  0x00007f6377b6b023 in  () at /lib/x86_64-linux-gnu/libQt6Core.so.6
#4  0x00007f6378836889 in QWidget::customContextMenuRequested(QPoint const&) () at /lib/x86_64-linux-gnu/libQt6Widgets.so.6

I have not been able to reproduce the second of the crashes.

On a side comment, it would have been nice to keep the crash fixes in a PR, and the other enhancement on its own PR.

Source/GUI/MemWatcher/MemWatchWidget.cpp Outdated Show resolved Hide resolved
@dreamsyntax
Copy link
Collaborator

dreamsyntax commented Aug 25, 2024

Clang format check failed
https://github.com/aldelaro5/dolphin-memory-engine/actions/runs/10548607990/job/29222766031#step:3:26

Run clang format and adjust the code it calls out in the above job

@cristian64 cristian64 merged commit 090d19d into aldelaro5:master Aug 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants