Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad JSON spacing/display + Upgrade vue-json-pretty 1.9.3->1.9.5 #93

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

philogicae
Copy link
Member

This is an old issue, I was tired to break my eyes on it everyday.
Keys were squashed vertically to the left in case of long text values, and the overall indentation was also broken.
Screenshots don't show it, but obviously nested JSONs still work as expected.

Before:
image

Now:
image

@hoh hoh requested review from gmolki and removed request for aliel August 7, 2024 12:42
Comment on lines 215 to 216
.vjs-tree {
word-wrap: normal !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Although I feel it can be a bit flakey. Have you tried creating a wrapper component for <vue-json-pretty> that overrides this word-wrap style?

@philogicae philogicae requested a review from gmolki August 7, 2024 15:26
Copy link
Member

@gmolki gmolki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 🔝

@gmolki gmolki merged commit c94cf6c into master Aug 7, 2024
1 check passed
@philogicae philogicae deleted the fix-json-spacing-display branch August 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants