Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

108 upgrade pydantic version #110

Merged
merged 13 commits into from
Oct 16, 2024
Merged

108 upgrade pydantic version #110

merged 13 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. feat: Upgrade the pydantic version

    Pydantic used to be in 1.10.5 now moving to up to v2 accepting from v2.x to the latest
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    be45061 View commit details
    Browse the repository at this point in the history
  2. Fix: Refactor ItemHash to align with Pydantic v2 validation schema.

    Replaced `__get_pydantic_core_schema__` with a more efficient schema
    handling using `core_schema.str_schema()` and custom validation for ItemHash.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bd469cb View commit details
    Browse the repository at this point in the history
  3. Fix: Refactor classes and functions to align with Pydantic v2.

    - Updated code to explicitly specify optional keys where necessary.
    - Replaced direct `.get` calls with `data.get()` to handle new validation logic.
    - Migrated model configuration to use `model_config = ConfigDict(extra="forbid")`
    or `model_config = ConfigDict(extra="allow")` in place of Pydantic v1's configuration style.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4d67c1f View commit details
    Browse the repository at this point in the history
  4. Fix: Refactor to use model_dump and model_dump_json in place of d…

    …eprecated methods.
    
    - Replaced `.dict()` with `.model_dump()` for model serialization.
    - Replaced deprecated `.json()` with `.model_dump_json()` for JSON serialization.
    
    These changes ensure compatibility with Pydantic v2 by using the updated serialization methods.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    097c46b View commit details
    Browse the repository at this point in the history
  5. Refactor to use model_dump and model_dump_json, and update `check…

    …_content` function for stricter comparison.
    
    - Replaced `.dict()` with `.model_dump()` for model serialization.
    - Replaced deprecated `.json()` with `.model_dump_json()` for JSON serialization.
    - Updated the `check_content` function to properly normalize and compare JSON structures,
    as Pydantic v2 enforces stricter validation and comparison rules.
    
    These changes ensure compatibility with Pydantic v2 by adopting
    the new serialization methods and handling stricter content comparison logic.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    da6e03d View commit details
    Browse the repository at this point in the history
  6. Fix: Changes in files to comply with MyPy, Ruff, and Black

    - Refactored the normalize_content function to respect MyPy.
    - Reformatted code according to Black.
    - Fixed linting issues raised by Ruff.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    debf926 View commit details
    Browse the repository at this point in the history
  7. Fix: Comply with Black

    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e15e187 View commit details
    Browse the repository at this point in the history
  8. Fix: Missing field caused by pydantic v2

    Some fields were missing and needed to be specified
    du to the v2 of pydantic.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    983655d View commit details
    Browse the repository at this point in the history
  9. Fix: Linter test did not pass and suggestion from Hugo

    Black test failed
    Wrong indentation on one line, add comment for custom_dump
    Refactoring normalize_content function from Hugo and added docstring
    for better comprehension
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    883852e View commit details
    Browse the repository at this point in the history
  10. Fix: Replacing print by logger and remove unecessary workaround

    Debuging using logger and not print
    Function to convert size always return the instance needed.
    Antonyjin authored and hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a59d74c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    87b3dc6 View commit details
    Browse the repository at this point in the history
  12. Cleanup with black, isort

    hoh committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2c79fca View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8e7435e View commit details
    Browse the repository at this point in the history