CI/CD: Code Quality Checks #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHHukiewitz
force-pushed
the
mhh-code-quality
branch
4 times, most recently
from
61d1b7c
to
5162f70
Compare
hoh
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Most of these tests are redundant with those in the test.yml workflow. What about uniting both or replacing it ?
Would it make sense switching to pyproject.toml and usign Hatchling similar to the aleph-vm implementation to make it easier to run these tests locally as a developer ?
MHHukiewitz
force-pushed
the
mhh-code-quality
branch
from
cad23b5
to
4313335
Compare
nesitor
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
black --checkruffmypy --check-untyped-defs