Implement Confidential message type #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort that kind of messages, that have a different schema from Instances and Programs. Solution: Create a Confidential message schema with concrete fields.
olethanh
reviewed
May 24, 2024
|
Related, PR #100 adds features required on the host for the VM, and could be used to schedule confidential VMs on nodes that support it. |
…ad of a new message type.
hoh
approved these changes
Jun 18, 2024
hoh
added a commit
that referenced
this pull request
Jun 21, 2024
* Problem: A user cannot create a Confidential VM because we don't support that kind of messages, that have a different schema from Instances and Programs. Solution: Create a Confidential message schema with concrete fields. * Fix: Removed old implementation and Added new one using a field instead of a new message type. * Fix: Solve code quality issues. * Fix: Solved test issues after last changes. * Fix: Solved code quality issues on tests caused by different black versions. * Fix: Solve mypy issue on CI. * Fix: Added missing firmware field for confidentials. * Add class TrustedExecutionEnvironment * Add comment on retro-compatibility * Improve tests --------- Co-authored-by: Andres D. Molins <[email protected]> Co-authored-by: Hugo Herter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: A user cannot create a Confidential VM because we don't support that kind of messages, that have a different schema from Instances and Programs.
Solution: Create a Confidential message schema with concrete fields.
Improvements:
aleph-vmpyalephandaleph-sdk-pythonrepositories.