Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dependencies were pinned too strictly #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hoh
Copy link
Member

@hoh hoh commented Sep 14, 2024

This prevented installing the SDK on some systems
such as Nix 24.05.

This prevented installing the SDK on some systems
such as Nix 24.05.
@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Sep 14, 2024
Copy link

"summary": "This PR involves a minor update to the dependencies list in pyproject.toml. The changes from specific versions (4.3.1 and 6.3.0) to more general versions (eth_typing>=4.0.0 and web3>=6.3.0) are likely to be non-breaking and do not introduce significant risks. The update is focused on flexibility and compatibility, which aligns with the 'BLUE' category, indicating a low complexity PR.",
"highlight": [
"- "eth_typing==4.3.1",",
"+ "eth_typing>=4.0.0",",
"- "web3==6.3.0",",
"+ "web3>=6.3.0","
]
}

@hoh hoh requested a review from philogicae September 16, 2024 12:21
@@ -32,8 +32,8 @@ dependencies = [
"typing_extensions",
"aioresponses>=0.7.6",
"aleph-superfluid>=0.2.1",
"eth_typing==4.3.1",
"web3==6.3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to add an upper bound version to enforce semver to avoid randomly breaking our installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants