Allow use major versions of Aleph SDK #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary version creates a dependency hell. Solution: Allow to use the same and major version of aleph-python-sdk library.
nesitor
force-pushed
the
andres-fix-allow_use_major_versions
branch
from
1dc23be
to
337250d
Compare
|
No change in setup.cfg related to |
nesitor
force-pushed
the
andres-fix-allow_use_major_versions
branch
from
3423097
to
9bfbf56
Compare
Yes, it's changed: https://github.com/aleph-im/aleph-vrf/pull/27/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52L51 |
MHHukiewitz
reviewed
Jan 12, 2024
nesitor
force-pushed
the
andres-fix-allow_use_major_versions
branch
from
9bfbf56
to
ec9f39a
Compare
nesitor
force-pushed
the
andres-fix-allow_use_major_versions
branch
from
ec9f39a
to
3f007c8
Compare
…ot major or minor.
|
@hoh you need to approve too, it seems |
# Conflicts: # src/aleph_vrf/coordinator/vrf.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Having a strong dependency to an exact aleph-python-sdk library version creates a dependency hell.
Solution: Allow to use the same and major version of aleph-python-sdk library.