Feature: upgrade balance endpoint #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1yam
changed the title
odesenfans
requested changes
Sep 4, 2023
odesenfans
changed the title
odesenfans
requested changes
Sep 4, 2023
tests/conftest.py
Outdated
| with session_factory() as session: | ||
| session.add(balance) | ||
| session.commit() | ||
| insert_volume_refs(session, fixture_instance_message) |
There was a problem hiding this comment.
I don't understand why you insert the volumes in this fixture, as it has nothing to do with the balance. I expect 3 fixtures:
instance_messageinstance_message_with_volumes_in_db(depends on the first one)user_balance(depends on nothing).
tests/api/test_balance.py
Outdated
| assert response.status == 200, await response.text() | ||
| data = await response.json() | ||
| assert data["balance"] == 22192 | ||
| assert data["locked_amount"] == 6 |
There was a problem hiding this comment.
How come this value is so low?
There was a problem hiding this comment.
cause i did only commit the volume and not instances
There was a problem hiding this comment.
Okay, what's the point of importing the instance fixture if you don't use it?
There was a problem hiding this comment.
now it's implement too, just miss to add
Co-authored-by: Olivier Desenfans <[email protected]>
odesenfans
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, the Balance API Endpoint only returns the total balance for an address. And user (also frontend) as no easy way to get number of locked token.
On :
/api/v0/addresses/{address}/balanceSolution:
Enhance the Balance API Endpoint to include the "locked_amount" field in the response, indicating the amount of tokens in use for a specific address.
Example:
{ "address": "0x9319Ad3B7A8E0eE24f2E639c40D8eD124C5520Ba", "balance": 22192, "locked_amount": 2726 }