Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue with instance messages and requirements empty field #599

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Aug 27, 2024

Problem: When a user send an instance message with the field requirements to null, the message is rejected.

Solution: Check if the requirements field have something relevant inside.

…ments` to null, the message is rejected.

Solution: Check if the `requirements` field have something relevant inside.
@nesitor nesitor self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (38f8fa7) to head (e79aa8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          91       91           
  Lines        4910     4910           
  Branches      677      677           
=======================================
  Hits         4634     4634           
  Misses        241      241           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor requested a review from hoh August 28, 2024 09:23
@nesitor nesitor merged commit 9802a41 into main Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants