Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema updates #112

Closed
wants to merge 13 commits into from
Closed

Schema updates #112

wants to merge 13 commits into from

Conversation

jsetton
Copy link

@jsetton jsetton commented Mar 11, 2019

Schema updates based on latest API reference documentation.

Changes:

  • Added error response color temperature controller specific not supported in current color mode
  • Added motion/contact sensors schema properties
  • Added equalizer controller schema capabilities and properties
  • Added playback controller schema capabilities
  • Added step speaker controller schema capabilities
  • Updated thermostat controller schema capabilities (Add missing property to ThermostatController validation schema #98)
  • Updated input controller schema capabilities and properties
  • Added security panel controller schema capabilities and properties
  • Added playback state reporter schema capabilities and properties
  • Added non-controllable mode range toggle property
  • Added latest text label locales
  • Added semantic extensions
  • Added latest display categories

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jsetton jsetton force-pushed the schema-updates branch 2 times, most recently from 72d9849 to 292453d Compare May 5, 2019 23:05
@jsetton
Copy link
Author

jsetton commented May 27, 2019

@DZhang87 It has been a while since I submitted this PR. Any chance that it could get merged at some point? This will definitely help the community.

@sleeping-barber
Copy link

Hi,
we encountered problems using the schema provided within the master branch. It seems to be related that the current schema is not support semantic at all. Please merge this request due to it fixes this problem. Thanks to @jsetton for fixing!

@NorthernMan54
Copy link

@jsetton Even though this has not been merged the community appreciates this PR. Tks

@fabltd
Copy link

fabltd commented Oct 9, 2020

Is there a schema for the mode controller?

@jsetton
Copy link
Author

jsetton commented Oct 18, 2020

I am going to close this request. The latest update #160 to the schema includes the majority of the changes I covered here including some minor fixes that were done to the API since then.

Some of the properties could use stricter enumeration list, based on the API reference documentation, such as the supported inputs for InputController or the supported text string locales for interfaces using resources configuration. But otherwise, the latest schema is working well based on my validation testing.

@jsetton jsetton closed this Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants