Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of special flair for monthly top 10 users #56

Merged
merged 3 commits into from
Apr 14, 2014
Merged

Initial implementation of special flair for monthly top 10 users #56

merged 3 commits into from
Apr 14, 2014

Conversation

amorde
Copy link
Contributor

@amorde amorde commented Apr 14, 2014

This is an initial implementation of the feature requested in #18

This uses the flair['top1'] and flair['top10'] values set in the config.json to add a special CSS class to the month's top earner and a different, special CSS class for the month's top 2-10 earners.

This clears last month's CSS flairs as well as this months, so that only 10 users have the special flairs at any given time.

The update_top_ten_css method only modifies the CSS class of the flair, not the actual value.

This HAS NOT BEEN TESTED. Although the tests pass, I have no real way of testing this without access to DeltaBot.

@amorde amorde changed the title Initial implementation of special flair for monthly top 10 users #18 Initial implementation of special flair for monthly top 10 users Apr 14, 2014
Snorrrlax added a commit that referenced this pull request Apr 14, 2014
Initial implementation of special flair for monthly top 10 users
@Snorrrlax Snorrrlax merged commit b644a42 into alexames:master Apr 14, 2014
@Snorrrlax
Copy link
Collaborator

Thanks for doing this.

We started running it, and there appears to be a bug. DeltaBot is deleting the flair text of some users, or rather when it updates the css class it forgets to re-add the text? I'm not sure...

It also makes the css class "top 1 pholder" and "top ten pholder" instead of just "top 1" and "top 10", was this deliberate?

@amorde
Copy link
Contributor Author

amorde commented Apr 15, 2014

The CSS classes are supposed to be defined in the JSON, that's where the "placeholder" values come from.

And I thought I only removed occurrences of the special classes from the CSS - I'll review it again

On Apr 15, 2014, at 3:38 PM, Snorrrlax [email protected] wrote:

Thanks for doing this.

We started running it, and there appears to be a bug. DeltaBot is deleting the flair text of some users, or rather when it updates the css class it forgets to re-add the text? I'm not sure...

It also makes the css class "top 1 pholder" and "top ten pholder" instead of just "top 1" and "top 10", was this deliberate?


Reply to this email directly or view it on GitHub.

@amorde
Copy link
Contributor Author

amorde commented Apr 17, 2014

So I've created a fix and pushed it to my fork, but the main repository is in a state that will not include all of the code if I submit a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants