Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For WASM, alloc rounds UP when dividing size by page size. #48

Merged
merged 1 commit into from
Feb 12, 2025
Merged

For WASM, alloc rounds UP when dividing size by page size. #48

merged 1 commit into from
Feb 12, 2025
+1 −1

Conversation

daniel-wong-dfinity-org
Copy link
Contributor

This way, alloc does not allocate too little.

This was discussed and agreed to in issue 47.

@daniel-wong-dfinity-org daniel-wong-dfinity-org mentioned this pull request Feb 12, 2025
Closed
alexcrichton
alexcrichton approved these changes Feb 12, 2025
View reviewed changes
Copy link
Owner

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton merged commit 1006940 into alexcrichton:main Feb 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-wong-dfinity-org @alexcrichton