Issue isn't implementation, it was test (only passing due to mocks). …

…Fixed tests.
alexdlaird · Nov 6, 2024 · 279f853 · 279f853
1 parent b3efd5a
commit 279f853
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/pyngrok/ngrok.py b/pyngrok/ngrok.py
@@ -318,12 +318,9 @@ def connect(addr: Optional[str] = None,
 
     _interpolate_tunnel_definition(pyngrok_config, options, addr, proto, name)
 
-    # proto can't also be passed when "labels" is defined
-    if proto is not None and "labels" in options:
-        proto = options.pop("proto")
-    else:
-        proto = options.get("proto")
-    name = options.get("name")
+    # Remove proto when "labels" is defined
+    if "labels" in options:
+        options.pop("proto")
 
     _upgrade_legacy_params(pyngrok_config, options)
 

diff --git a/tests/test_ngrok.py b/tests/test_ngrok.py
@@ -942,7 +942,6 @@ def test_full_tunnel_definitions(self, mock_get_ngrok_process, mock_api_request)
         config = {
             "tunnels": {
                 "my-tunnel": {
-                    "proto": "tcp",
                     "domain": "pyngrok.com",
                     "addr": "5000",
                     "inspect": "false",