Skip to content

Commit

Permalink
Removed deprecated "region" param from config provisioning.
Browse files Browse the repository at this point in the history
  • Loading branch information
alexdlaird committed Nov 7, 2024
1 parent 897953c commit 685b234
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased](https://github.com/alexdlaird/pyngrok/compare/7.2.1...HEAD)

- Changed

`region` parameter is no longer provisioned in default v2 config, as [it is deprecated by `ngrok`](https://ngrok.com/docs/agent/config/v2/#region).

## [7.2.1](https://github.com/alexdlaird/pyngrok/compare/7.2.0...7.2.1) - 2024-11-04

### Added
Expand Down
2 changes: 1 addition & 1 deletion pyngrok/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def get_default_config(ngrok_version: Optional[str]) -> Dict[str, Any]:
if ngrok_version == "v2":
return {}
elif ngrok_version == "v3":
return {"version": "2", "region": "us"}
return {"version": "2"}
else:
raise PyngrokError(f"\"ngrok_version\" must be a supported version: {SUPPORTED_NGROK_VERSIONS}")

Expand Down

0 comments on commit 685b234

Please sign in to comment.