Encode parmeters for metrics-server

As reported by @jeka, this change escapes the commas in the "args" parameter to the helm chart. Tested before/after the patch and confirmed that all options are now being passed to the deployment. Closes: #73 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
alexellis · Oct 28, 2019 · 0ff2d67 · 0ff2d67
1 parent 9193ccf
commit 0ff2d67
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/cmd/metricsserver_app.go b/pkg/cmd/metricsserver_app.go
@@ -66,7 +66,7 @@ func makeInstallMetricsServer() *cobra.Command {
 		}
 
 		overrides := map[string]string{}
-		overrides["args"] = `{--kubelet-insecure-tls,--kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname}`
+		overrides["args"] = `{--kubelet-insecure-tls,--kubelet-preferred-address-types=InternalIP\,ExternalIP\,Hostname}`
 		fmt.Println("Chart path: ", chartPath)
 		outputPath := path.Join(chartPath, "metrics-server/rendered")