-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #225 from aleximmer/asdfghjkl
Make importing `asdfghjkl` conditional to the installed optional dependency
- Loading branch information
Showing
19 changed files
with
854 additions
and
244 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,10 +20,15 @@ jobs: | |
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install pytest | ||
pip install pytest-mock | ||
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu | ||
pip install -e . | ||
- name: Test without the old asdfghjkl | ||
run: | | ||
pip uninstall -y asdfghjkl-old | ||
pytest tests | ||
- name: Test with pytest | ||
run: | | ||
pip install pytest | ||
pip install pytest-mock | ||
pip install git+https://[email protected]/wiseodd/asdl@asdfghjkl | ||
pytest tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,14 +56,14 @@ The [code](https://github.com/runame/laplace-redux) to reproduce the experiments | |
To install laplace with `pip`, run the following: | ||
|
||
```bash | ||
pip install git+https://github.com/aleximmer/laplace@update-deps | ||
pip install laplace-torch | ||
``` | ||
|
||
> [!WARNING] | ||
> The ASDL dependency has recently been updated and it breaks the compatibility with | ||
> `laplace-torch`. Please _do not_ install `laplace-torch` from `pip` or the `main` | ||
> branch. Instead install it as above, from the `update-deps` branch. | ||
> We're actively fixing this issue. | ||
Additionally, if you want to use the `asdfghjkl` backend, please install it via: | ||
|
||
```bash | ||
pip install git+https://[email protected]/wiseodd/asdl@asdfghjkl | ||
``` | ||
|
||
For development purposes, e.g. if you would like to make contributions, | ||
clone the repository and then install: | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.