Merge pull request jellyfin#55 from YouKnowBlom/srt-fix

Add external srt support
alexmaras · Aug 19, 2020 · 1f0f0bb · 1f0f0bb
2 parents 4743243 + 1f48039
commit 1f0f0bb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/helpers.js b/src/helpers.js
@@ -419,9 +419,12 @@ export function createStreamInfo(item, mediaSource, startPosition) {
     var subtitleTracks = []
     subtitleStreams.forEach(function (subtitleStream) {
         let subStreamCodec = subtitleStream.Codec.toLowerCase();
-        if (subStreamCodec !== 'vtt' && subStreamCodec !== 'webvtt') {
-            /* the CAF v3 player only supports vtt currently,
-            support for more could be added with a custom implementation*/
+        if (subStreamCodec !== 'vtt' &&
+            subStreamCodec !== 'webvtt' &&
+            (subStreamCodec === 'srt' && subtitleStream.DeliveryMethod !== "External")) {
+            /* The CAF v3 player only supports vtt currently,
+            SRT subs can be "transcoded" to vtt by jellyfin.
+            Support for more could be added with a custom implementation */
             return;
         }
         var textStreamUrl = subtitleStream.IsExternalUrl ? subtitleStream.DeliveryUrl : (getUrl(item.serverAddress, subtitleStream.DeliveryUrl));