Running type tests on CI #93
Conversation
size-limit report 📦
|
|
I think I will run these as standard |
| listener(event: MouseEvent) { | ||
| const value: number = event.button; | ||
| listener(event) { | ||
| expectTypeOf(event).toEqualTypeOf<MouseEvent>(); |
There was a problem hiding this comment.
@Andarist this is currently failing as event is being inferred by TS as any
There was a problem hiding this comment.
Any suggestion on how to resolve this?
| export type Listener<TTarget extends EventTarget, TEvent extends Event> = | ||
| | ListenerObject<TEvent> | ||
| | { (this: TTarget, ev: TEvent): void }; | ||
| export type Listener<TTarget extends EventTarget, TType extends string = string> = |
There was a problem hiding this comment.
@Andarist I am keen for your thoughts here. I
moved Listener back to taking a string rather than an Event in order to maintain the previous type signature. Autocomplete seems to be continuing to work great.
There was a problem hiding this comment.
After this change the only breaking change would be the type signature of bindAll
There was a problem hiding this comment.
Or this is bad because we have separate calculating of what TEvent is, rather that a single inference at the root? 🤔
|
With all my type changes reverted, i am currently getting the
|
Hey @Andarist it looks like the type tests I setup are now failing as a part of #44. I will have a go at fixing them