[enhancement] decode/encode original-style config in any hardware id #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decode: Save the configuration file's hardware ID in hex format in key _nvramcfg_saved_hwid_hex. - Encode: Write the hardware ID using the hex value in key _nvramcfg_saved_hwid_hex. If the key doesn't exist then use 0c000000 as a fallback for backwards compatibility. Prior to this change only configuration files with hardware id 0c000000 could be decoded/encoded in original format, and it wasn't saved in the decoded output. Closes doublerebel#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode: Save the configuration file's hardware ID in hex format in key
_nvramcfg_saved_hwid_hex.
Encode: Write the hardware ID using the hex value in key
_nvramcfg_saved_hwid_hex. If the key doesn't exist then use 0c000000
as a fallback for backwards compatibility.
Prior to this change only configuration files with hardware id 0c000000
could be decoded/encoded in original format, and it wasn't saved in the
decoded output.
Closes doublerebel#7