forked from wundergraph/graphql-go-tools
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Implement Multi fetch #3
Open
alexus37
wants to merge
14
commits into
master
Choose a base branch
from
multi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi refactored
jensneuse
reviewed
Nov 29, 2024
processor.ProcessFetchTree(input) | ||
expected := resolve.Sequence( | ||
resolve.Single(&resolve.SingleFetch{FetchDependencies: resolve.FetchDependencies{FetchID: 0}}), | ||
resolve.Parallel( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add an additional post processing step that replaces a Parallel Node in the root with the child if the child length is 1.
jensneuse
reviewed
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant enhancements to the post-processing capabilities of the
graphql-go-tools
package, specifically in the management of fetch tree nodes. The key modifications include the introduction of a newMulti
fetch tree node type, updates to the loader to accommodate this new node type, and the addition of corresponding test cases to verify the functionality of these enhancements.The rationale behind this change is to alleviate the load on a subgraph when a router resolves a query. The primary objective is to consolidate multiple requests, which typically execute in parallel, into a single "Multi" request.
This approach represents a trade-off between capacity and performance.
The overall implementation is executed in a two-step process:
The Multi Node Post Processor
This post-processor analyzes parallel nodes and generates multi nodes for all Entity or Batch Entity fetches directed to the same data source (subgraph).
The Multi Loader
This loader operates in a two-step manner: first, it utilizes all the fetches to create a Multi request using aliases; second, it disentangles the response into the appropriate paths for each fetch.
For example, two fetches like this would be combined into a single Multi fetch:
Result:
Limitations and Future Work
I would like to emphasize that this is a proof of concept (PoC) and that several adjustments are necessary for proper implementation: