Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github Actions and use PropEr github revision #224

Merged
merged 15 commits into from
Nov 28, 2023
Merged

Fix Github Actions and use PropEr github revision #224

merged 15 commits into from
Nov 28, 2023

Conversation

evnu
Copy link
Collaborator

@evnu evnu commented Oct 20, 2023 •
edited
Loading

This PR does multiple things to fix github actions:

  • Reference PropEr from github (a5ae5669f01143b0828fc21667d4f5e344aa760b). This also fixes (UndefinedFunctionError) function :eunit_lib.fun_parent/1 is undefined or private #217
  • Bump versions of the actions in use
  • Use only newer versions of Elixir and Erlang
  • Bump versions of the dependencies
  • Remove dialyxir
  • Remove coverex
  • Tag a failing instrument test as will_fail
  • Delete obsolete Mix.Config
  • Use Logger.warning instead of Logger.warn
  • Apply lint suggestions w.r.t. Enum.filter() |> Enum.count(), apply/3 and Enum.map_join/3

Fix #217

@evnu evnu mentioned this pull request Oct 20, 2023
Closed
@evnu evnu force-pushed the fix-ci branch 3 times, most recently from aeb6889 to 0f833c0 Compare October 20, 2023 20:35
evnu added 14 commits October 20, 2023 22:50
@evnu
Use Logger.warning instead of Logger.warn
595d80a
@evnu
ci: Update actions and check only recent Elixir+OTP versions
ec09814
@evnu
ci: Exclude OTP 26 for now
5701c25
@evnu
ci: Reenable OTP 26+Elixir v1.15+v1.14
ad19830
@evnu
ci: Silence tests
942187a
@evnu
ci: Remove tracing and coverage
b3818fd 
Coverage is quite low, and tracing slows down the tests. Coverage should
be handled again, but only for a single runner and not in the matrix
itself.
@evnu
deps: update versions
43a8a3b
@evnu
deps: Use github revision for proper
5d1f2dd
@evnu
deps: remove dialyxir
5cf5619 
This resolves this error:

** (UndefinedFunctionError) function Dialyxir.Output.info/1 is undefined (module Dialyxir.Output is not available)
    (dialyxir 1.4.1) Dialyxir.Output.info("Finding suitable PLTs")
    (dialyxir 1.4.1) lib/mix/tasks/dialyzer.ex:174: Mix.Tasks.Dialyzer.run/1
    (mix 1.15.6) lib/mix/task.ex:447: anonymous fn/3 in Mix.Task.run_task/5
    (mix 1.15.6) lib/mix/task.ex:506: Mix.Task.run_alias/6
    (mix 1.15.6) lib/mix/cli.ex:92: Mix.CLI.run_task/2
    /usr/bin/mix:2: (file)
[1]    104215 exit 1     mix lint
@evnu
deps: remove non-functional coverex
e715cf3
@evnu
lint: Use Enum.count/2, Enum.map_join/3 and avoid apply/2 with known …
52b41d2 
…number of args
@evnu
tests: set test coverage threshold to pass
9b34da2
@evnu
tests: tag failing instrumentation test will_fail
7c1a277
@evnu
tests: use LOG_LEVEL or default to info
42fde6e
@evnu evnu marked this pull request as ready for review October 20, 2023 20:53
@evnu evnu requested a review from alfert October 20, 2023 20:53
@evnu evnu changed the title Fix Github Actions Fix Github Actions and use PropEr github revision Oct 20, 2023
@evnu
Copy link
Collaborator Author

evnu commented Oct 20, 2023 •
edited
Loading

@alfert can you take a look into the branch protection rules, something is amiss here w.r.t. naming of the jobs. That' might be why the obsolete old jobs are still listed here. See https://github.com/orgs/community/discussions/25720
image

@evnu
Copy link
Collaborator Author

evnu commented Nov 8, 2023

@alfert ping; how should we proceed here?

@coop
Copy link

coop commented Nov 28, 2023

These changes look great. I love that #217 is resolved. I'm going to use your branch until this is resolved.

@alfert
Copy link
Owner

alfert commented Nov 28, 2023

Hey @evnu, sorry for being so long in stasis.

I deleted all the branch protection rules for Elixir 1.7 to 1.11

alfert
alfert approved these changes Nov 28, 2023
View reviewed changes
Copy link
Owner

@alfert alfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! 💚

@alfert alfert merged commit af61cf1 into alfert:master Nov 28, 2023
5 checks passed
@evnu evnu deleted the fix-ci branch November 28, 2023 12:24
@evnu evnu mentioned this pull request Mar 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfert alfert alfert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(UndefinedFunctionError) function :eunit_lib.fun_parent/1 is undefined or private
3 participants
@evnu @coop @alfert