[1.x] Fix broken behavior for 308 redirects #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this would unconditionally panic: ``` thread '<unnamed>' panicked at 'attempt to subtract with overflow', /home/joshua/src/rust/ureq/src/unit.rs:244:59 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ```
jyn514
changed the title
|
Thanks for the fix! Can you add a unittest that would detect the bug? |
|
By the way, for the |
|
Done, I made sure it failed on master. |
jsha
approved these changes
Dec 6, 2020
|
Great, I'll cut a release with the fix. |
|
Published: https://crates.io/crates/ureq/1.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this would unconditionally panic:
Follow-up to #253. Sorry for not testing earlier!