Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Determine the URL to connect to after middleware finishes #745

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

benferse
Copy link
Contributor

Make sure that the URL that's used to establish the transport connection is parsed after middleware runs, in case the middleware made any changes to the URL itself (added query string params, changed the URL itself, etc.)

Fixes: #741

@benferse benferse marked this pull request as ready for review March 27, 2024 18:28
@algesten algesten merged commit 71be542 into algesten:main Apr 3, 2024
50 checks passed
@algesten
Copy link
Owner

algesten commented Apr 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware cannot modify query string parameters?
3 participants