performance: Speculative block assembly into master #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into yossi/specblockasm
…test spec asm: Add race unit test
|
nicholasguoalgorand seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
* workaround interface changes
* small tweaks, note TODOs
* cleanup
s/OnNewSpeculativeBlock/StartSpeculativeBlockAssembly/g
rm player.SpeculativeAssemblyDeadline
* simplify demux
* test fixes, works at least -short
* comment
* TODO comments
* expand StartSpeculativeBlockAssembly to take the block header digest
* wip: pool rehacking passes tests
* fix TestSpeculativeBlockAssemblyDataRace
better locking in tryReadSpeculativeBlock()
start thread in StartSpeculativeBlockAssembly()
* fix
* simplify SpeculativeBlockAssemblyGraceTime to SpeculativeAsmTimeOffset
remove player.SpeculativeAsmTimeDuration field
* improve speculative block assembly starting
start spec asm at filterTimeout-offset and again at soft-vote
cleanup
* lint cleanup
* nolint comment
* fix copyright header
* Post merge fixes
* fix GetCreatorForRound which was breaking e2e test
* make generate
* review comment
* SpeculativeAsmTimeOffset typo, 400ms
* algod_speculative_assembly_discarded metric
* start speculative assembly on proposal validation
* StartSpeculativeBlockAssembly(...,onlyIfStarted)
* algod_speculative_assembly_discarded_{start,read,ONB}
* code review feedback
* fix a test by ignoring intermittent speculative block action
Co-authored-by: Pavel Zbitskiy <[email protected]>
cce
force-pushed
the
feature/specblockasm
branch
from
341a804
to
d42feb0
Compare
Specblockasm master 2ba3f4b
cce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.