Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Reorganize block generator scripts. #5582

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jul 19, 2023

Summary

Cleanup the block-generator root directory by moving dev scripts into a script subdirectory and removing the run_test.sh script.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #5582 (d9d90b1) into master (fbfbea1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
+ Coverage   55.80%   55.82%   +0.02%     
==========================================
  Files         446      446              
  Lines       63486    63486              
==========================================
+ Hits        35430    35443      +13     
+ Misses      25680    25674       -6     
+ Partials     2376     2369       -7     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review July 19, 2023 15:42
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks reasonable. I think it's worth seeing which commands in the Makefile have been broken -if any- and then for the broken ones, triage and decide whether to:

  • fix
  • remove
  • comment out with a TODO comment indicating future fix

shiqizng
shiqizng previously approved these changes Jul 19, 2023
@winder
Copy link
Contributor Author

winder commented Jul 21, 2023

@tzaffi Thanks, I think I fixed the only Makefile problem.

@winder winder requested review from tzaffi and shiqizng July 21, 2023 14:28
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winder winder merged commit b4f6b1f into algorand:master Jul 21, 2023
10 checks passed
@winder winder deleted the will/generator-snap-test branch July 21, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants