-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Reorganize block generator scripts. #5582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5582 +/- ##
==========================================
+ Coverage 55.80% 55.82% +0.02%
==========================================
Files 446 446
Lines 63486 63486
==========================================
+ Hits 35430 35443 +13
+ Misses 25680 25674 -6
+ Partials 2376 2369 -7 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks reasonable. I think it's worth seeing which commands in the Makefile
have been broken -if any- and then for the broken ones, triage and decide whether to:
- fix
- remove
- comment out with a TODO comment indicating future fix
@tzaffi Thanks, I think I fixed the only Makefile problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Cleanup the block-generator root directory by moving dev scripts into a
script
subdirectory and removing therun_test.sh
script.