chore: use ++ instead of +=

[kehiy]

Summary

I used ++ instead of =+
they do the same thing but the ++ is more readable and more properly

[kehiy]

@winder @algoanne
can you review please

[codecov]

Codecov Report

Merging #5597 (43dd59a) into master (197bfb6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5597   +/-   ##
=======================================
  Coverage   55.79%   55.80%           
=======================================
  Files         446      446           
  Lines       63490    63490           
=======================================
+ Hits        35424    35430    +6     
+ Misses      25695    25692    -3     
+ Partials     2371     2368    -3     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tzaffi]

Thanks @kehiy for your pull request.

Though in most contexts I agree that ++ is preferable to += 1 in this specific context of a simulation I disagree. For the case of generate.go I don't see an obvious reason why we'd want to skip a generation and add a number different than 1. However, in the case of generate_test.go it's already the case that sometimes we add numbers greater than 1 to intra so it's definitely clearer to use += 1 here. Summarizing, since this is a simulation and the amount we're advancing by is not a-priori 1, I think we should continue using the same style as before and not adopt ++.

[kehiy]

@tzaffi yep, that makes sense.
I'm going to close this PR, thanks for reviewing.