ledger: add pebbledb support #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5606 +/- ##
==========================================
- Coverage 54.97% 54.95% -0.02%
==========================================
Files 463 463
Lines 64494 64505 +11
==========================================
- Hits 35456 35450 -6
- Misses 26655 26674 +19
+ Partials 2383 2381 -2
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlgoAxel
reviewed
Jul 28, 2023
algorandskiy
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Looks good, two concerns about the hardocded configuration.
- max open files should be lowered and the formula in server.go updated if driver="pebble" is selected.
- 4GB per mem table is too high for npn
Additionally, please comment, modifying of which config options might lead to performance issues for existing pebble DBs.
|
@algorandskiy the default config is for 32 MB per memtable, with 2 memtables, not 4 GB. |
|
ah, this is max, not actual, ok |
algorandskiy
previously approved these changes
Aug 8, 2023
AlgoAxel
previously approved these changes
Aug 9, 2023
algorandskiy
reviewed
Aug 9, 2023
algorandskiy
approved these changes
Aug 9, 2023
AlgoAxel
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are breaking down #5212 in several smaller PRs to make it more digestible.
This is PRs "numero 4" on the KV epic.
Content:
Test Plan
Existing tests.