-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Generate langspec for each version #5629
AVM: Generate langspec for each version #5629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5629 +/- ##
==========================================
- Coverage 55.36% 55.32% -0.04%
==========================================
Files 466 466
Lines 65733 65723 -10
==========================================
- Hits 36394 36364 -30
- Misses 26883 26906 +23
+ Partials 2456 2453 -3
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to coordinate with the process that gets the docs onto the website, since there is no TEAL_opcodes.md
any more. I imagine we either want to create it, as a copy of the last version or (I think better) the process that copies them into place should copy and link to them all. @JasonWeathersby
Created algorandfoundation/docs#1156 to update the docs site with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'd like to get this merged soon, so I can work out how it changes the process of giving spec changes to the Foundation. (probably pretty minimal)
786ac77
Summary
Addresses #5131, which asks for a
langpsec.json
file to be generated for each TEAL version.I've also generated the
TEAL_opcodes.md
file for each version, since I view this as the human-readable equivalent oflangspec.json
.Now the files
langpsec_v%d.json
andTEAL_opcodes_v%d.md
will be generated for each version.Test Plan
Documentation-only change