Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: precompile block-generator teal code #5642

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Aug 8, 2023

Summary

Observed that the block generator was taking 3-10 seconds to generate app-heavy scenarios. After inspecting the code I found that the teal program was being compiled over and over again.

Testing

Added timing instrumentation to measure the performance impact with the stress.50000.yml benchmark scenario.

The generation time was reduced from 7 seconds to 250ms.

Code review video: https://youtu.be/JlYhksWUBKU

@winder winder requested review from tzaffi and shiqizng August 8, 2023 16:28
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #5642 (5e31835) into master (95e3504) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5642      +/-   ##
==========================================
- Coverage   55.01%   54.98%   -0.04%     
==========================================
  Files         463      463              
  Lines       64513    64513              
==========================================
- Hits        35495    35471      -24     
- Misses      26640    26658      +18     
- Partials     2378     2384       +6     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder self-assigned this Aug 8, 2023
@winder winder marked this pull request as ready for review August 8, 2023 18:05
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement

@winder winder merged commit 208335f into algorand:master Aug 9, 2023
11 of 12 checks passed
@winder winder deleted the will/precompile-teal branch August 9, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants