catchup: make unsupported block handling more deterministic #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The catchup code had a race where, upon seeing an unsupported block in the future, the catchup logic would cancel the current pipeline of block fetches. Depending on the timing, this might either make some progress or not fetch any blocks at all. The new logic is more deterministic: it tries to always fetch all blocks up until the last supported block, and when the ledger reaches the last supported block, the catchup service stops.
Codecov Report
@@ Coverage Diff @@
## master #5673 +/- ##
==========================================
+ Coverage 55.15% 55.16% +0.01%
==========================================
Files 465 465
Lines 65003 65011 +8
==========================================
+ Hits 35850 35862 +12
- Misses 26760 26761 +1
+ Partials 2393 2388 -5
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
previously approved these changes
Aug 16, 2023
There was a problem hiding this comment.
This is a welcome fix. However, I share @algorandskiy 's concern.
I have a suggestion to trigger the monitor only after an unsupported is detected.
I have a draft for this here.
|
Fair enough. How about the change I just pushed, to start the |
|
the GH-CI integration stuck, closing and reopening to retrigger. |
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The catchup code had a race where, upon seeing an unsupported block in the future, the catchup logic would cancel the current pipeline of block fetches. Depending on the timing, this might either make some progress or not fetch any blocks at all.
The new logic is more deterministic: it tries to always fetch all blocks up until the last supported block, and when the ledger reaches the last supported block, the catchup service stops.