network: fix misplaced p2p received TX metric #6144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6144 +/- ##
=======================================
Coverage 56.28% 56.28%
=======================================
Files 494 494
Lines 69958 69958
=======================================
+ Hits 39375 39378 +3
+ Misses 27912 27904 -8
- Partials 2671 2676 +5 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-more-metrics
branch
2 times, most recently
from
8586d2e
to
0bdaf73
Compare
algorandskiy
changed the title
algorandskiy
force-pushed
the
pavel/p2p-more-metrics
branch
from
0bdaf73
to
8fec6f8
Compare
algorandskiy
changed the title
cce
previously approved these changes
Oct 22, 2024
algorandskiy
commented
Oct 22, 2024
gmalouf
approved these changes
Oct 23, 2024
cce
approved these changes
Oct 28, 2024
|
Most of this was already merged in #6147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved metrics to RecvRPC to count them as early as possible similarly to wsnet.
Test Plan
Existing tests