Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: handle p2p to ws messages propagation #6156

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

algorandskiy
Copy link
Contributor

Summary

When a pure p2p node sends a transaction to a hybrid node, it gets stuck in p2p-only gossipsub mesh due to missing Relay call. Fixed by adding net.Relay call to the validation pipeline in tx handler.
It is safe since the pubsub code has duplicate check before actual transmitting over the network.

Test Plan

Added a new unit test

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.29%. Comparing base (39f7485) to head (3ef71a5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6156      +/-   ##
==========================================
+ Coverage   56.28%   56.29%   +0.01%     
==========================================
  Files         494      494              
  Lines       69958    69959       +1     
==========================================
+ Hits        39375    39386      +11     
+ Misses      27912    27887      -25     
- Partials     2671     2686      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant