API: New algod endpoint /v2/header/{round}/header omits transactions and cert from response
#6163
+1,671
−1,327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve only the block header (sans transactions)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6163 +/- ##
==========================================
+ Coverage 55.99% 56.24% +0.24%
==========================================
Files 494 494
Lines 69958 69978 +20
==========================================
+ Hits 39174 39360 +186
+ Misses 28077 27939 -138
+ Partials 2707 2679 -28 ☔ View full report in Codecov by Sentry. |
algorandskiy
requested changes
Nov 4, 2024
algorandskiy
approved these changes
Nov 5, 2024
gmalouf
reviewed
Nov 5, 2024
| } | ||
|
|
||
| // Encoding wasn't working well without embedding "real" objects. | ||
| response := struct { |
There was a problem hiding this comment.
Should this be a defined type somewhere, or do we think single use-case/good enough?
gmalouf
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve just the block header information without the transactions and cert data. This reduces the response size and response time, but still includes block details such as the proposer and any incentive rewards.
With the introduction of consensus incentives, various people have asked how they can obtain this new data per block without also including all the transaction data in the response. This was considered a useful option, so thought I'd have a go at implementing it. Support for both json and msgpack is available, and a very simple test was included.