Issue-271/SDK jar not compatible with old Android Runtimes #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android 4.x runtime loads an ancient org.apache.commons.codec jar which is incompatible and shadowed org.apache.commons.codec.binary.Base64.decode without the decode method. This backports the Base64.java and BaseNCodec.java into the `utils` package and references this from `Encoder` so we get a working Base64 decode on Android 4. Thanks to https://github.com/timmolter
# Conflicts: # src/main/java/com/algorand/algosdk/util/Encoder.java
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android 4.x runtime loads an ancient org.apache.commons.codec jar which is incompatible and shadowed org.apache.commons.codec.binary.Base64.decode without implementing the decode method.
This backports the Base64.java and BaseNCodec.java into the
utilspackage and references this fromEncoderso we get a working Base64 decode on Android 4.I have pulled the entire files in so they can be easily comapred with the originals - alternatively, we could trim them down but this would impact that traceability - happy either way.
Thanks to https://github.com/timmolter