-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW FEATURE PROPOSAL: ALGORAND MULTI-LANGUAGE PASSPHRASE SUPPORT #748
base: develop
Are you sure you want to change the base?
Conversation
|
||
The English wordlist selected here remains unchanged | ||
All other wordlists except Arabic and Indonesian, were originally done by Bitcoin developers under BIP-39 | ||
Arabic wordlist has been selected from https://arabeyes.org - Online Arab Linux/Unix Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more concrete link for the Arabic wordlist? I wasn't able to find the list. Similar remark regarding Indonesian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is where I sorted them from, for Arabic find github repo here: https://github.com/a3f/arabic-wordlists .
I used the Arabeyes wordlist, as the community there had worked on a technical dictionary already with Arabic words, see Arabeyes here: https://arabeyes.org/Download_technical_dictionary . However, as you can see from the Arabic Wordlist repo, there are many other options i.e
- hans-wehr: Hans Wehr's Dictionary of Modern Written Arabic, English version edited by J Milton Cowan
- quran: The Quran in modern Arabic writing style.
- arabeyes: Arab eyes Technical Arabic-English dictionary
- arwiki: The Arabic Wikipedia on 2016-09-20. Not that useful, I guess, because of the many foreign terms and occasional typos
- arzwiki: The Egyptian-Arabic Wikipedia on 2016-09-20
- ar-php: ar-extra-stopwords.txt from the Ar-PHP project
For Indonesian, here is the link: https://github.com/geovedi/indonesian-wordlist . But, as you can see, Google Code Archive shelved the links for the wordlists. I added the Indonesian wordlist for 2011 - Google Code Archive.
Thanks! @tzaffi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I corrected and added concrete links to the files.
One quick question, do you think it is necessary to add entropy functions for the wordlists? Thanks.
Add concrete links for Arabic wordlist and Indonesian wordlist
This is a new feature proposal, to enable multi-language support for Algorand Wallet Passphrases. It was raised as an issue here: algorand/go-algorand#5215 .
This PR needs a review before adoption. Here are the issues: