feat: expose AtomicTransactionComposer.methodCalls

[joe-p]

Makes AtomicTransactionComposer.methodCalls public. This is useful for modifying/retrieving the method calls in an ATC externally.

Specifically useful for algorandfoundation/algokit-utils-ts#234

[jasonpaulos]

I'd prefer you leave the field as it was, but introduce a new getter method like getMethodCalls which returns a copy of the map.

That helps with maintainability and prevents clients from unintentionally modifying the internal map

[joe-p]

The problem is that modifying the map is sometimes necessary. For example, if you have an ABI method call that takes in another ABI method call as an argument. The ATC does not currently support this, so you need to get the appl transaction and update methodCalls if you want the return values. I suppose we could add support for that, but it would be a larger change to the ATC.

[jasonpaulos]

If that's the use case you're pursuing, then yes I think we need to talk about how the interface can support that. Directly modifying the internal map is not a stable solution

[joe-p]

I suppose we could also have a method setMethodCall(idx: number, method: ABIMethod) in addition to getMethodCalls

[joe-p]

And there can be sanity checks that it's an appl that doesn't already have a method set

[robdmoore]

Idea: what if we allow you to optionally pass in an ABIMethod when you call addTransaction? and then have a readonly property to expose method calls so you can read them out after using addMethodCall. Those two together would suffice?