-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added None
checking in min_balance
validation
#271
Conversation
Can make more changes like this for keeping general coding style, if you approve this changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change, thank you! Please feel free to add additional checks.
Also I think you might have to sign the CLA for this to be checked in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this after tests pass...
edit: It looks like the tests were written without this query in mind - we'd also have to change the existing tests to make this pass the CI so we'll have to hold this off
Unfortunately this is a more systemic issue. The tests here expect that We could decide to switch this behavior, but that would affect all the SDKs. Related to algorand/js-algorand-sdk#414 as well |
#507 supersedes this PR. |
Added
None
checking inmin_balance
validating condition so the user can look up for balances with more than 0 amount.