Update voting example #596
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
reviewed
Nov 8, 2022
ahangsu
reviewed
Nov 8, 2022
Comment on lines
+32
to
+33
| @router.method(name="open") | ||
| def open_poll() -> Expr: |
There was a problem hiding this comment.
good to see naming overriding being used 👍
Co-authored-by: Zeph Grunschlag <[email protected]>
tzaffi
reviewed
Nov 15, 2022
|
|
||
| @router.method(no_op=CallConfig.CREATE) | ||
| def create( | ||
| options: abi.StaticArray[abi.String, Literal[3]], can_resubmit: abi.Bool |
There was a problem hiding this comment.
If we really want more choices, we could have a factory that takes N = the number of choices as a parameter and returns the router. But it seems overcomplicates for the demo, so I would prefer it to be kept this way. But we could still mention that it's easily achievable.
tzaffi
reviewed
Nov 15, 2022
| return Seq( | ||
| App.globalPut(open_key, Int(0)), | ||
| App.globalPut(resubmit_key, can_resubmit.get()), | ||
| App.globalPut(option_name_keys[0], options[0].use(lambda value: value.get())), |
There was a problem hiding this comment.
sanity checking that a more direct approach for setting the value isn't available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.