Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nil pointer dereference when adding new accounts #132

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tasosbit
Copy link
Contributor

@tasosbit tasosbit commented Jan 22, 2025

ℹ Overview

  • fixed race condition in ShouldAddIncentivesFee

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

Copy link

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe79792
Status: ✅  Deploy successful!
Preview URL: https://27ddbdb0.nodekit-run.pages.dev
Branch Preview URL: https://fix-incentive-logic-nil-poin.nodekit-run.pages.dev

View logs

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.91%. Comparing base (90b769d) to head (fe79792).
Report is 6 commits behind head on v1.2.0.

❗ There is a different number of reports uploaded between BASE (90b769d) and HEAD (fe79792). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (90b769d) HEAD (fe79792)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.2.0     #132       +/-   ##
===========================================
- Coverage   44.40%   32.91%   -11.50%     
===========================================
  Files          76       76               
  Lines        6308     6308               
===========================================
- Hits         2801     2076      -725     
- Misses       3277     4121      +844     
+ Partials      230      111      -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero PhearZero merged commit 75c883f into v1.2.0 Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants