Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modals #136

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: modals #136

wants to merge 6 commits into from

Conversation

PhearZero
Copy link
Member

@PhearZero PhearZero commented Jan 23, 2025

ℹ Overview

Split this into two PRs due to the size of the changes. This pr covers the following

  • separate state between Overlay and Modals as much as possible
  • introduces a Modal interface for modals to implement
  • stage the modals/overlay for a refactor of the event bus

@PhearZero PhearZero self-assigned this Jan 23, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b04f44
Status: ✅  Deploy successful!
Preview URL: https://4b140e6d.nodekit-run.pages.dev
Branch Preview URL: https://refactor-modals.nodekit-run.pages.dev

View logs

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 86.71875% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.14%. Comparing base (f852911) to head (6b04f44).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ui/modals/generate/controller.go 58.33% 10 Missing ⚠️
ui/modals/transaction/view.go 72.72% 6 Missing and 3 partials ⚠️
ui/modal/controller.go 22.22% 7 Missing ⚠️
ui/modals/info/info.go 91.48% 3 Missing and 1 partial ⚠️
ui/modals/generate/view.go 95.55% 1 Missing and 1 partial ⚠️
ui/modals/transaction/controller.go 66.66% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f852911) and HEAD (6b04f44). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f852911) HEAD (6b04f44)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #136       +/-   ##
===========================================
- Coverage   43.97%   33.14%   -10.84%     
===========================================
  Files          76       76               
  Lines        6342     6393       +51     
===========================================
- Hits         2789     2119      -670     
- Misses       3320     4160      +840     
+ Partials      233      114      -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero PhearZero marked this pull request as ready for review January 27, 2025 21:01
@PhearZero PhearZero linked an issue Jan 28, 2025 that may be closed by this pull request
4 tasks
@PhearZero PhearZero requested a review from tasosbit January 28, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Refactor modal components
1 participant