Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Range): convert to TypeScript, impove docs and tests, closes #4602 #4939

Merged
merged 2 commits into from
Oct 11, 2024
Merged

refactor(Range): convert to TypeScript, impove docs and tests, closes #4602 #4939

merged 2 commits into from
Oct 11, 2024

Conversation

wangw11056
Copy link
Collaborator

closes #4602

@eternalsky eternalsky closed this Sep 18, 2024
@eternalsky eternalsky reopened this Sep 23, 2024
@eternalsky eternalsky linked an issue Sep 23, 2024 that may be closed by this pull request
【Technical upgrade】Range #4602
Closed
eternalsky
eternalsky requested changes Sep 23, 2024
View reviewed changes
components/range/__docs__/demo/basic/index.tsx Outdated Show resolved Hide resolved
components/range/__docs__/demo/control/index.tsx Outdated Show resolved Hide resolved
components/range/__docs__/demo/fixedWidth/index.tsx Outdated Show resolved Hide resolved
components/range/__docs__/demo/fixedWidth/index.tsx Outdated Show resolved Hide resolved
components/range/__docs__/demo/tipRender/index.tsx Outdated Show resolved Hide resolved
components/range/view/range.tsx Outdated Show resolved Hide resolved
components/range/view/range.tsx Outdated Show resolved Hide resolved
components/range/view/range.tsx Outdated Show resolved Hide resolved
components/range/view/slider.tsx Outdated Show resolved Hide resolved
components/range/view/range.tsx Show resolved Hide resolved
@wangw11056 wangw11056 force-pushed the refactor/Range branch 2 times, most recently from 7c192b1 to a6009e3 Compare September 27, 2024 03:13
eternalsky
eternalsky requested changes Oct 10, 2024
View reviewed changes
components/range/__docs__/demo/control/index.tsx Outdated Show resolved Hide resolved
components/range/__tests__/index-spec.tsx Show resolved Hide resolved
components/range/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/range/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/range/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/range/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/range/index.tsx Outdated Show resolved Hide resolved
components/range/index.tsx Outdated Show resolved Hide resolved
components/range/types.ts Show resolved Hide resolved
components/range/view/range.tsx Show resolved Hide resolved
eternalsky
eternalsky approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@eternalsky eternalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eternalsky eternalsky merged commit d93eda1 into alibaba-fusion:next Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternalsky eternalsky eternalsky approved these changes

Assignees
No one assigned
Labels
Technical Upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Range
2 participants
@wangw11056 @eternalsky